add a sync after flush cache when doing benchmark #2503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-penkin
requested review from
ZzEeKkAa,
anmyachev,
chengjunlu,
etiotto and
whitneywhtsang
Contributor
|
Side note: wall time measurements could be inaccurate. |
etiotto
approved these changes
Oct 18, 2024
alexbaden
approved these changes
Oct 18, 2024
Contributor
alexbaden
left a comment
alexbaden
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing some benchmarks in pytorch and I find this benchmark always record the time of flush cache kernel. I want to add a sync in each iteration before kernel start. Pytorch calls this function here: https://github.com/pytorch/pytorch/blob/main/torch/_inductor/runtime/benchmarking.py#L176